Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling when Cloudformation resources are converted to the wrong Terraform resource. #187

Open
shadycuz opened this issue Jul 9, 2023 · 0 comments

Comments

@shadycuz
Copy link
Member

shadycuz commented Jul 9, 2023

It's possible that a Cloudformation resource will get converted to the wrong terraform resource. Perhaps its because the resource is custom #186 . Maybe its just a bad match. We have the match percentage but often the correct match is a really low percentage.

Searcing for events rule in terraform docs...
Best match was cloudwatch event rule at /tmp/terraform_src/website/docs/r/cloudwatch_event_rule.html.markdown with score of 62.

The only think I can think of, is before every resource, write the Cloudformation logical ID and resource type that it was converted from.

Something like

// Converted from MyEventsRule (AWS::Events::Rule)
resource "aws_cloudwatch_event_rule" "my_events_rule" {
  name        = "foo"
}

That way, if the resource match is wrong, at least they can see about fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant