Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Docker combatibility version #78

Open
Corshi opened this issue Nov 19, 2022 · 6 comments
Open

[Suggestion] Docker combatibility version #78

Corshi opened this issue Nov 19, 2022 · 6 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@Corshi
Copy link

Corshi commented Nov 19, 2022

Not a real issue. This extension is just not working with docker variation of WEBUI.
https://github.com/AbdBarho/stable-diffusion-webui-docker

I have OS that refuses to install normal AUTOMATIC1111'a repo.
This extension requires to move the files to the core of it.
...well, that is not allowed in docker, as all files are nicely backed-up and run in separate "virtual machine" - of some sorts.
(That way it is even easier and safer to run. Control over memory used is very easy that way.)
...and I cant edit main files of the repo.

If there is someone willing to make a alternative of this extension - that would work with docker version, It would be nice.

that is all... sorry to bother.

@DominikDoom
Copy link
Owner

This extension requires to move the files to the core of it

I'm not really sure what you mean by that? Don't all extensions need to be installed inside the /extensions folder of the webui?
I can't really change that if docker doesn't support it or the webui has problems loading them.

@DominikDoom
Copy link
Owner

DominikDoom commented Nov 19, 2022

Actually, I just had a look in the repo you looked and think the issue is this in the dockerfile:
WORKDIR ${ROOT}/repositories/stable-diffusion
The workdir is not the same as the webui root. This extension needs to know where it is installed to find the config and tag files in javascript, so it leads to issues when scripts are run from another directory. Some colabs had similar path issues.

Please try the following:
In line 8 of scripts/tag_autocomplete_helper.py

# Webui root path
FILE_DIR = Path().absolute()

Change it to FILE_DIR = "/stable-diffusion-webui" as a test.
If my guess is right, this might solve it due to path checks being relative to the main dir again. This won't be a permanent solution, but you could fork the extension and change it there, if I don't find out a solution that fits both local and docker installs.

@DominikDoom DominikDoom self-assigned this Nov 19, 2022
@DominikDoom DominikDoom added bug Something isn't working enhancement New feature or request labels Nov 19, 2022
@DominikDoom
Copy link
Owner

To give a few more infos on this:
As discussed in this issue AbdBarho/stable-diffusion-webui-docker#216 it was indeed the working directory preventing the initial load, however another problem related to Gradio's file serving functionality has popped up, which might take a while to fix and seems out of my scope for now.

@Corshi
Copy link
Author

Corshi commented Nov 20, 2022

As of this "This extension requires to move the files to the core of it." I just miss read things on front page. Sorry for causing confusion.
I also tried the hings you suggested. I even tried different directories of the installation, but nothing worked.
I tried to sent this message before, but had internet problems...

Well, now I see the other bug report you linked, so all I want to say now, is that I'm grateful to you, for trying and spending your time on this subject.
Thanks

@xiaxichen
Copy link

I have A error for this docker
image
what should i do , to fix this error?

@DominikDoom
Copy link
Owner

@xiaxichen See the last few comments in AbdBarho/stable-diffusion-webui-docker#216, this error is related to how Gradio works with loading files in javascript for security reasons. I can't fix it from my side for now, it essentially requires a different setup for adding the extensions to the docker image, which depends on the developers of the docker image or on gradio to properly support symlinks created by the docker mount process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants