Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change PutPages() visibility to protected #35

Open
eesau opened this issue Jan 21, 2019 · 2 comments
Open

Change PutPages() visibility to protected #35

eesau opened this issue Jan 21, 2019 · 2 comments

Comments

@eesau
Copy link

eesau commented Jan 21, 2019

In order to use PageGroups (http://fpdf.org/en/script/script57.php) in my subclass I have to change PutPages() visibility from private to protected after every tfpdf update. I see no harm in changing the visibility of methods to protected by default.
@kazsaj
Copy link

kazsaj commented Jan 21, 2019

Hello,

I don't see a reason why not. If you could create a PR, I'm sure we will get it merged.

@eesau eesau mentioned this issue Jan 21, 2019
Merged
@kazsaj
Copy link

kazsaj commented Jan 21, 2019

This is now available in https://github.com/DocnetUK/tfpdf/releases/tag/v2.2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eesau @kazsaj