Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modal dismissal button doesn't work by default #16

Open
bcardarella opened this issue Nov 15, 2024 · 0 comments
Open

modal dismissal button doesn't work by default #16

bcardarella opened this issue Nov 15, 2024 · 0 comments

Comments

@bcardarella
Copy link
Member

The default value for on_cancel is just an empty %JS{} struct. Instead it should default to JS.hide with the supplied id to hide the modal.

esc and clicking off the modal both work by default but the supplied close button does not
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bcardarella