Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change summary lang key default value to "the page" #75

Open
nahuelhds opened this issue May 6, 2020 · 2 comments
Open

Change summary lang key default value to "the page" #75

nahuelhds opened this issue May 6, 2020 · 2 comments

Comments

@nahuelhds
Copy link
Contributor

As stated by @edsu at #74

All that being said, maybe it's best to stick with summary since that is what Readability calls it, and its what is in the model. But I think the default string value should be "the page"?

@edsu
Copy link
Member

edsu commented May 7, 2020

Sorry, my mistake. I think leaving the key as summary works since it matches the data model. I thought that there might be a default value, but it appears that there is not?

@nahuelhds
Copy link
Contributor Author

nahuelhds commented May 21, 2020

There is no default value because every code I've added to the project was intended for adding features without affecting the current default behavior that the engine already has.

I'm thinking that we could set a default value if we add a new prop for enable/disable this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants