Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement an oracle interface for a 2-price oracle as required by Djed Shu #21

Closed
2 tasks
ceilican opened this issue Mar 19, 2024 · 2 comments
Closed
2 tasks
Labels
good first issue Good for newcomers

Comments

@ceilican
Copy link
Contributor

See #20 for context.

The current oracle interface (https://github.com/DjedAlliance/Djed-Solidity/blob/main/src/IOracle.sol) assumes that the oracle provides only one price.

But Djed Shu needs an oracle that provides two prices.

Therefore, we need to do the following:

  • duplicate IOracle.sol and rename it to IOracleShu.sol
  • in IOracleShu.sol, replace the single readData function by a readMaxPrice and a readMinPrice functions.
@keshav-nischal
Copy link
Contributor

I would like to work on this issue

@ceilican
Copy link
Contributor Author

ceilican commented May 7, 2024

Thanks, @keshav-nischal !

@ceilican ceilican closed this as completed May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants