Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #8 Added Department Field while adding a new tag #42

Closed
wants to merge 2 commits into from
Closed

Fixes #8 Added Department Field while adding a new tag #42

wants to merge 2 commits into from

Conversation

Hrishabh598
Copy link
Contributor

@DjangoCRM I have changed some things so that the issue would be solved by the method suggested by you please do review it once. If there are any issues i am happy to help. Fixes #8 .

@Hrishabh598 Hrishabh598 marked this pull request as ready for review September 18, 2024 12:50
@DjangoCRM
Copy link
Owner

@Hrishabh598 Well, almost.
You didn't notice that the Tag model inherits the department field so there is no need to add it.
There is also no need to add this field to TagForm since it is a ModelForm and the department field is already added.
I wrote a detailed instruction in my comment #8 on how to fix it. Please read it.
If you have any difficulties, create a draft pull request and ask.
Will you try again?

@DjangoCRM DjangoCRM added the requires changes Pull requests that need to be updated based on reviewers' comments and then reviewed again label Sep 19, 2024
@Hrishabh598 Hrishabh598 closed this by deleting the head repository Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
requires changes Pull requests that need to be updated based on reviewers' comments and then reviewed again
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error while adding tags. ( First select a department. )
2 participants
@Hrishabh598 @DjangoCRM