You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Today I was setting up LightDM when I found your theme and really liked it. The only issue was that it crashed on most occasions when I went to go use it. From the logs, I was able to find this error: file:///usr/share/lightdm-webkit/themes/archlinux/js/greeter.js:12:28: CONSOLE ERROR TypeError: null is not an object (evaluating 'user.image.length'). Upon further inspection, I found that user.image is null if there isn't an image, not an empty string. So, to fix this, I simply replaced var imageSrc = user.image.length > 0 ? user.image : tux; with var imageSrc = user.image ? user.image : tux; on line 12 of greeter.js. This still works even if user.image is an empty string as far as my tests in Chromium's debugger go.
The text was updated successfully, but these errors were encountered:
aiudirog
added a commit
to aiudirog/lightdm-webkit-theme-archlinux
that referenced
this issue
Dec 31, 2016
Today I was setting up LightDM when I found your theme and really liked it. The only issue was that it crashed on most occasions when I went to go use it. From the logs, I was able to find this error:
file:///usr/share/lightdm-webkit/themes/archlinux/js/greeter.js:12:28: CONSOLE ERROR TypeError: null is not an object (evaluating 'user.image.length')
. Upon further inspection, I found that user.image is null if there isn't an image, not an empty string. So, to fix this, I simply replacedvar imageSrc = user.image.length > 0 ? user.image : tux;
withvar imageSrc = user.image ? user.image : tux;
on line 12 of greeter.js. This still works even if user.image is an empty string as far as my tests in Chromium's debugger go.The text was updated successfully, but these errors were encountered: