You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The function responsible for identifying URL names is get_url() which currently errors when unrecognized URL names are given to it. To allow URLs to be append to as is and from names at the same time, append_to_url() ignores errors and assumes the pass through text is the URL to append to (not always the case, above).
Identification of URLs by name should be consolidated to get_url() and return NA when input is not recognized. append_to_url() can then determine if the input matches a standard URL regex or was an unrecognized.
It might be a good idea to add an argument to get_url() to specify how to handle non-matches (error, return NA, etc.).
The text was updated successfully, but these errors were encountered:
Using unrecognized names for URLs produces unusable hyperlinks in
build_hyperlink()
.Created on 2023-08-17 by the reprex package (v2.0.1)
The function responsible for identifying URL names is
get_url()
which currently errors when unrecognized URL names are given to it. To allow URLs to be append to as is and from names at the same time,append_to_url()
ignores errors and assumes the pass through text is the URL to append to (not always the case, above).DO.utils/R/append.R
Lines 113 to 119 in 64d8b7c
Identification of URLs by name should be consolidated to
get_url()
and returnNA
when input is not recognized.append_to_url()
can then determine if the input matches a standard URL regex or was an unrecognized.It might be a good idea to add an argument to
get_url()
to specify how to handle non-matches (error, returnNA
, etc.).The text was updated successfully, but these errors were encountered: