Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATM10 Update 1.20 Includes Supplimentaries which causes the JDT Inventory Holder to CDT game #283

Open
zeziba opened this issue Nov 16, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@zeziba
Copy link

zeziba commented Nov 16, 2024

Just Dire Things version

1.4.9

Minecraft Version

1.21.1

(Neo)Forge Version

21.1.77

Modpack & Version

ATM10 1.20

Do you have optifine or Rubidium installed?

No

Describe the issue

Supplimentaries causes JDT Inventory Holder to CDT game

Steps to reproduce

  1. Have ATM10
  2. Open MC
  3. Place JDT inventory holders
  4. Insert assorted armors including ATM armors
  5. Wear cosmetic items

Expected behaviour

Not to CDT

Screenshots

No response

Log files

https://gist.github.com/zeziba/3ecf6cec28318428b3be575700f13a57

Additional information

The log states that JDTs failed to render due to

Caused by: java.lang.ClassCastException: class com.direwolf20.justdirethings.client.blockentityrenders.InventoryHolderBER$1 cannot be cast to class net.mehvahdjukaar.supplementaries.api.IQuiverEntity (com.direwolf20.justdirethings.client.blockentityrenders.InventoryHolderBER$1 is in module [email protected] of loader 'TRANSFORMER' @5950054d; net.mehvahdjukaar.supplementaries.api.IQuiverEntity is in module [email protected] of loader 'TRANSFORMER' @5950054d)

If that is the be-all end-all no idea but here we are.

Issue in the ATM10 is AllTheMods/ATM-10#1161

@zeziba zeziba added the bug Something isn't working label Nov 16, 2024
@oatmealmanFG
Copy link

even after a pack update that pushes supplimentaries back into the game, its broken. my son cant join my lan game unless we delete this broken mod

@zeziba
Copy link
Author

zeziba commented Nov 23, 2024

@oatmealmanFG I just disable supplimentaries for the moment as it tends to cause a bunch of issues outside of just this Direwolf one.

What I think the JDT's needs to add though is an ignore for errors like this though so they stop causing a CTD, logging it would be nice but that could be added to a config with an internal flag so that it doesn't spam the logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants