jaxdecomp proto #21
Open
jaxdecomp proto #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EiffL
reviewed
Jul 18, 2024
EiffL
reviewed
Jul 19, 2024
ASKabalan
commented
Jul 19, 2024
scripts/particle_mesh.slurm
Outdated
| @@ -0,0 +1,167 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
This file should not stay in the repo in my opinion
Co-authored-by: Francois Lanusse <[email protected]>
ASKabalan
force-pushed
the
ASKabalan/jaxdecomp_proto
branch
from
b39627f to
b32014b
Compare
|
@all-contributors please add @ASKabalan for code and infrastructure, @aboucaud for review, @hsimonfroy for code |
|
I've put up a pull request to add @ASKabalan! 🎉 |
|
@all-contributors please add @aboucaud for review |
|
I've put up a pull request to add @aboucaud! 🎉 |
|
@EiffL I just noticed that the all contributer bot did not add Hugo and Alex |
|
Hello @EiffL The test workflow is passing Everything is good to go This PR is getting too huge and I would like to merge it Can you please merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am going to continue here the distributed PM