Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filename Parsing Plug-in function request #1084

Open
hucurve opened this issue Oct 3, 2024 · 3 comments · May be fixed by #1096
Open

Filename Parsing Plug-in function request #1084

hucurve opened this issue Oct 3, 2024 · 3 comments · May be fixed by #1096

Comments

@hucurve
Copy link

hucurve commented Oct 3, 2024

image
I'm using the built-in Plug-in for file metadata recognition, which I think is very useful and robust, but I still have two pain points that I hope to resolve one day:
1.Only the first can be recognized when multiple artists are present, while the others are in others
My file name =[黒ねずみいぬ, 市川和秀, 猪去バンセ, カサイこーめい, きしぐま, SUV, 重丸しげる, ちんぱん☆Mk-Ⅱ, ばんじゃく, 英, ふぁい, 水樹 凱, やさごり]XXXX.zip
image

2.I often change the original file name, and after re-scanning, the changed file will not trigger the plug-in, but still use the original name. There is also no way to select the changed file in the batch tool. This often confuses me

I hope someone can see my request, anyway I still like LRR this beautiful software:)

@Difegue
Copy link
Owner

Difegue commented Oct 12, 2024

This is a bit unconventional as far as using the naming standard goes, but I think it'd be pretty easy to check if the tags contain commas after regex parsing and assign the namespace to each one.

@Difegue Difegue added this to the Volunteers welcome milestone Oct 12, 2024
@IceBreeze
Copy link
Contributor

I was toying with this plugin a bit and this was an issue that I wasn't sure whether I wanted to handle or not.
This could also be applied to "groups", "series" and "languages" as well, but I knew for certain that at least the series can have a comma in their names.

I was going to break down just the language string where I can verify the generated tokens, but I can do the same for the rest and blindly accept the result.
It should be refined, but I can make a PR to dicuss.

@Difegue
Copy link
Owner

Difegue commented Oct 17, 2024

I think it makes sense to have this behavior for language and groups.
Series can have commas, but for those I think we should take them out as it'll break the tag storage.

I do wonder if groups with commas in their names exist.. I don't think that'd be too common.

@IceBreeze IceBreeze linked a pull request Oct 20, 2024 that will close this issue
@Difegue Difegue linked a pull request Oct 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants