Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS support #11

Open
tmaslen opened this issue Aug 1, 2018 · 1 comment
Open

HTTPS support #11

tmaslen opened this issue Aug 1, 2018 · 1 comment

Comments

@tmaslen
Copy link

tmaslen commented Aug 1, 2018

Hello again,

Have you thought about providing HTTPS support?

I got a crude version working by adding this code into Server.js...

const https = require('https');
const fs = require('fs');
const options = {
    cert: fs.readFileSync('/Users/tmo2367/Certs/localhost-cert.pem'),
    key: fs.readFileSync('/Users/tmo2367/Certs/localhost-key.pem'),
    passphrase: 'XXXXX'
};
https.createServer(options, this.app).listen(8443);

You'd want HTTPS to be enabled via a flag, and also the 3 option values too.

This is useful as I'm doing AWS Cognito integration, passing the user back to your serverless app requires a HTTPS URL to be added into Cognito.

Shall I make a PR if you're interested and not already started this?

Thanks,
/t

@tmaslen
Copy link
Author

tmaslen commented Aug 1, 2018

featureflagtech@f3a2001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant