sort by language type before sorting by score

Diaoul · Oct 7, 2024 · afa239a · afa239a
1 parent 06df560
commit afa239a
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/subliminal/core.py b/subliminal/core.py
@@ -148,7 +148,7 @@ def list_subtitles_provider(self, provider: str, video: Video, languages: Set[La
         try:
             return self[provider].list_subtitles(video, provider_languages)
         except Exception as e:  # noqa: BLE001
-            handle_exception(e, 'Provider {provider}')
+            handle_exception(e, f'Provider {provider}')
 
         return []
 
@@ -251,10 +251,14 @@ def download_best_subtitles(
         # ignore subtitles
         subtitles = [s for s in subtitles if s.id not in ignore_subtitles]
 
-        # filter by hearing impaired and foreign only
+        # sort by hearing impaired and foreign only
         language_type = LanguageType.from_flags(hearing_impaired=hearing_impaired, foreign_only=foreign_only)
         if language_type != LanguageType.UNKNOWN:
-            subtitles = [s for s in subtitles if s.language_type == language_type]
+            subtitles = sorted(
+                subtitles,
+                key=lambda s: s.language_type == language_type,
+                reverse=True,
+            )
 
         # sort subtitles by score
         scored_subtitles = sorted(