-
Notifications
You must be signed in to change notification settings - Fork 5
Skip gh pages publishing for forks? #136
Comments
Interesting, I was under the impression that you could always push to the |
https://github.com/evalott100/event-model/actions/runs/5044101600/jobs/9046917635#step:10:196 I'm thinking this is probably a permission thing - setting up the bot incorrectly? |
Surprising, public forks are given a read only token, so cannot write back to the fork: This doesn't seem intuitive, I can see why it shouldn't be able to write back to the original repo, but why can't it write to itself? Maybe this is something that #133 would fix for us if we worked out how to make it work with multiple versions... @gilesknap @garryod any ideas? |
@coretl my reading of that page is that the fork gets a read only token for actions fired by a pull request back to the original repo. The implication being that it has the usual permissions for its own actions. I thought the issue Eva reports is just that gh-pages is not set up on the fork? #133 also needs settings in the glpages section of your repo to work so would not improve this. |
The error in the logs is |
hmmm. Mr. peaceiris himself claims that this does work using But I tried it and first it failed to create the gh-pages branch, I manually added that, set the pages option up on that branch and then got the same as Eva:
Perhaps this has changed since March 2020? |
Is this worth an issue on the |
Should skip publishing to gh-pages for a fork |
If origin org is different from the fork org then skip publishing |
When a skeleton repo is forked, gh pages publishing will inevitably fail unless the org/user sets up their own docs pages:
This isn't a huge problem since on a PR to the upstream repo the correct org will be used and doc publishing can be seen to be working before a merge. Though... might be worth skipping this step for forked repos, or fixing it so the upstream org is used? @gilesknap @coretl
The text was updated successfully, but these errors were encountered: