Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run the linkcheck test on tag because of race condition #209

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

coretl
Copy link
Contributor

@coretl coretl commented Oct 30, 2024

Only run linkcheck if not on a tag, as the CI might not have pushed the docs for this tag yet, so we will fail:

https://github.com/DiamondLightSource/python-copier-template/actions/runs/11589736293/job/32265857983

line   28) broken    https://diamondlightsource.github.io/python-copier-template/2.4.0/how-to.html - 404 Client Error: Not Found for url: [https://diamondlightsource.github.io/python-copier-template/2.4.0/how-to.html\n(how-to/contribute:](https://diamondlightsource.github.io/python-copier-template/2.4.0/how-to.html/n(how-to/contribute:)

@coretl coretl requested a review from evalott100 October 30, 2024 09:36
@coretl coretl merged commit b40a871 into main Oct 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants