Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dependencies checker to the release workflow #199

Closed
wants to merge 2 commits into from

Conversation

stan-dot
Copy link
Contributor

@stan-dot stan-dot commented Oct 8, 2024

Fixes #182

@stan-dot stan-dot added the github_actions Pull requests that update GitHub Actions code label Oct 8, 2024
@stan-dot stan-dot requested a review from coretl October 8, 2024 08:26
@stan-dot stan-dot self-assigned this Oct 8, 2024
@stan-dot
Copy link
Contributor Author

stan-dot commented Oct 8, 2024

no idea why is this failing, the change in this PR was to the release workflow logic, which was not even ran here

FAILED tests/test_example.py::test_example_repo_updates - AssertionError: You are downgrading from 2.3.0 to 2.1.0.post31.dev0+56b5bde. Downgrades are not supported.
  
assert 1 == 0
 +  where 1 = CompletedProcess(args=['copier', 'update', '--trust', '--vcs-ref=HEAD', '--data-file', '/home/runner/work/python-copier-template/python-copier-template/example-answers.yml'], returncode=1, stdout=b'You are downgrading from 2.3.0 to 2.1.0.post31.dev0+56b5bde. Downgrades are not supported.\n').returncode
 

@coretl
Copy link
Contributor

coretl commented Oct 8, 2024

no idea why is this failing, the change in this PR was to the release workflow logic, which was not even ran here

FAILED tests/test_example.py::test_example_repo_updates - AssertionError: You are downgrading from 2.3.0 to 2.1.0.post31.dev0+56b5bde. Downgrades are not supported.
  
assert 1 == 0
 +  where 1 = CompletedProcess(args=['copier', 'update', '--trust', '--vcs-ref=HEAD', '--data-file', '/home/runner/work/python-copier-template/python-copier-template/example-answers.yml'], returncode=1, stdout=b'You are downgrading from 2.3.0 to 2.1.0.post31.dev0+56b5bde. Downgrades are not supported.\n').returncode
 

Part of the CI updates the example repo, so you need to rebase any PRs on main. This is 39 commits behind main at the moment, which means it tries to downgrade the example repo as part of the checks

@coretl
Copy link
Contributor

coretl commented Oct 8, 2024

Please also provide:

  • A reason why we should add this
  • What prompted you to add this
  • A project where it is in use and providing useful output
  • Details on whether it is checking just the project requirements or also the dev extra requirements

@stan-dot
Copy link
Contributor Author

stan-dot commented Oct 8, 2024

I just added 'fixes issue'

#182

@stan-dot
Copy link
Contributor Author

stan-dot commented Oct 8, 2024

maybe I forgot about the part where it's tested in a separate project

@stan-dot stan-dot force-pushed the 169-add-updating-the-lockfile-instructions branch from 56b5bde to 576b509 Compare October 8, 2024 11:35
@coretl
Copy link
Contributor

coretl commented Oct 8, 2024

Please add this to another project first and report back the useful information that it produced so we can review if it's worth adding

@stan-dot
Copy link
Contributor Author

stan-dot commented Oct 8, 2024

ok

@stan-dot
Copy link
Contributor Author

stan-dot commented Oct 8, 2024

@stan-dot
Copy link
Contributor Author

this particular PR is no longer needed, as the chosen then package isn't well maintained and proved problematic in dodal

potential alternative packages:
DiamondLightSource/dodal#861 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a github action for licensing compliance checker
3 participants