Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import linter doesn't catch everything #696

Open
olliesilvester opened this issue Dec 3, 2024 · 0 comments
Open

Import linter doesn't catch everything #696

olliesilvester opened this issue Dec 3, 2024 · 0 comments

Comments

@olliesilvester
Copy link
Contributor

olliesilvester commented Dec 3, 2024 •
edited
Loading

In #652, I had imported some hyperion files into mx_bluesky.common and the linting still passed. We should make sure the import linter catches this.

Specifically, it was in mx_bluesky.common.parameters.gridscan.py:
from mx_bluesky.hyperion.parameters.constants import CONST

Acceptance Criteria

  • Extra rules for the import-linter in CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@olliesilvester