Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requesting badly formatted PVs breaks metrics parsing #92

Open
AlexanderWells-diamond opened this issue Aug 2, 2023 · 1 comment
Open

Comments

@AlexanderWells-diamond
Copy link
Contributor

If you request a PV using a clearly incorrect syntax, e.g. CALC\\\{(A%2)\}(BL05J-VA-IOC-02:HEARTBEAT), this string will appear as-is in the metrics overview. This particular string breaks the parsing of the metrics completely, and so no Coniql metrics appear in Prometheus.

We will need to do some escaping of strings. There may be functionality in aioprometheus for such behaviour. I'm sort of surprised it doesn't automatically escape strings...

@AlexanderWells-diamond
Copy link
Contributor Author

I think aioprometheus should do some validation of this - I raised claws/aioprometheus#91.

We can still apply our own escaping to the labels before passing them on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant