From 72fd1e3eb602844ad2139f68897d7a923ea63b52 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jose=20Andre=CC=81s=20Granero?= Date: Mon, 15 Jan 2024 16:03:15 +0100 Subject: [PATCH] fix(FloatingHelper): fixed removed props. --- .../components/FloatingHelper/FloatingHelper.mdx | 8 +++----- .../components/FloatingHelper/FloatingHelper.tsx | 13 ++----------- .../InlineMessagePanel/InlineMessagePanel.tsx | 1 + 3 files changed, 6 insertions(+), 16 deletions(-) diff --git a/packages/core/src/components/FloatingHelper/FloatingHelper.mdx b/packages/core/src/components/FloatingHelper/FloatingHelper.mdx index a70b35506..5d8c79b86 100644 --- a/packages/core/src/components/FloatingHelper/FloatingHelper.mdx +++ b/packages/core/src/components/FloatingHelper/FloatingHelper.mdx @@ -9,14 +9,12 @@ import * as Stories from './FloatingHelper.stories'; ## Overview Component that provides a floating message to assist the user with a particular task or input. +Usually is used to provide helping info to the user when is filling a form, and we want to save +screen space avoiding use docked helpers in the fields. ## How to import - + ## Basic usage diff --git a/packages/core/src/components/FloatingHelper/FloatingHelper.tsx b/packages/core/src/components/FloatingHelper/FloatingHelper.tsx index 13b153fe8..57e9ae560 100644 --- a/packages/core/src/components/FloatingHelper/FloatingHelper.tsx +++ b/packages/core/src/components/FloatingHelper/FloatingHelper.tsx @@ -4,31 +4,22 @@ import { Typography, InlineMessage, HelperProps } from '..'; import { HELPER_ICON_BUTTON_SIZE_MAP } from '../Helper/constants'; import { hasStatus } from '../../utils/validations'; -export interface FloatingHelperProps extends HelperProps { - visible?: boolean; - setVisible?: (isVisible: boolean) => void; -} - -export const FloatingHelper: React.FC = ({ +export const FloatingHelper: React.FC = ({ id, - visible = false, message, size = 'md', - setVisible, status = 'base', tooltip, }) => { return ( - {message} + {message} ); diff --git a/packages/core/src/components/InlineMessage/components/InlineMessagePanel/InlineMessagePanel.tsx b/packages/core/src/components/InlineMessage/components/InlineMessagePanel/InlineMessagePanel.tsx index 631761924..8221ea732 100644 --- a/packages/core/src/components/InlineMessage/components/InlineMessagePanel/InlineMessagePanel.tsx +++ b/packages/core/src/components/InlineMessage/components/InlineMessagePanel/InlineMessagePanel.tsx @@ -75,6 +75,7 @@ export const InlineMessagePanel: React.FC = ({ {children}