Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort [workspace.dependencies], [workspace.dev-dependencies], and [workspace.build-dependencies] #54

Open
nipunn1313 opened this issue Nov 6, 2022 · 4 comments · May be fixed by #55
Open

Sort [workspace.dependencies], [workspace.dev-dependencies], and [workspace.build-dependencies] #54

nipunn1313 opened this issue Nov 6, 2022 · 4 comments · May be fixed by #55

Comments

@nipunn1313
Copy link

The new workspace inheritance feature adds these fields. Would love for them to be sorted by this tool!
nipunn1313 added a commit to nipunn1313/cargo-sort that referenced this issue Nov 6, 2022
@nipunn1313
Sort workspace dependencies
8606671 
Part of the new workspace dependencies feature described here
https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#inheriting-a-dependency-from-a-workspace

Fixes DevinR528#54
@nipunn1313 nipunn1313 linked a pull request Nov 6, 2022 that will close this issue
Open
@eirenik0
Copy link

eirenik0 commented Sep 7, 2023

I would like to see this feature as well :)

@bryantbiggs bryantbiggs mentioned this issue Sep 19, 2023
Merged
@reubenmiller reubenmiller mentioned this issue Oct 26, 2023
Merged
11 tasks
@extrawurst
Copy link

surprised to see how old this issue is, but these days cargo sort just chokes on workspaces using this feature:

thread 'main' panicked at /Users/stephan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cargo-sort-1.0.9/src/sort.rs:113:46:
called `Result::unwrap()` on an `Err` value: TomlError { message: "TOML parse error at line 14, column 7\n   |\n14 | chrono.workspace = true\n   |       ^\nUnexpected `.`\nExpected `=`\n" }
stack backtrace:
   0:        0x10043031c - std::backtrace_rs::backtrace::libunwind::trace::h2966c6fbfac9d426
                               at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/../../backtrace/src/backtrace/libunwind.rs:104:5
   1:        0x10043031c - std::backtrace_rs::backtrace::trace_unsynchronized::h8a5f4aefe890b7c5
                               at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5
   2:        0x10043031c - std::sys_common::backtrace::_print_fmt::h7574dd98fd39c257
                               at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/sys_common/backtrace.rs:67:5
   3:        0x10043031c - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h298c9ab285ff3934
                               at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/sys_common/backtrace.rs:44:22
   4:        0x100449b08 - core::fmt::rt::Argument::fmt::hf9661447f7b99899
                               at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/core/src/fmt/rt.rs:142:9
   5:        0x100449b08 - core::fmt::write::h4e276abdb6d0c2a1
                               at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/core/src/fmt/mod.rs:1120:17
   6:        0x10042e584 - std::io::Write::write_fmt::hd421848f5f0bf9d0
                               at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/io/mod.rs:1762:15
   7:        0x100430158 - std::sys_common::backtrace::_print::h09e653c6686dbd70
                               at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/sys_common/backtrace.rs:47:5
   8:        0x100430158 - std::sys_common::backtrace::print::hd8bd9ecab1f94b94
                               at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/sys_common/backtrace.rs:34:9
   9:        0x100431578 - std::panicking::default_hook::{{closure}}::h520eeb743fc98fb4
  10:        0x1004312c0 - std::panicking::default_hook::ha6550ffe49b63df1
                               at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/panicking.rs:292:9
  11:        0x1004319a0 - std::panicking::rust_panic_with_hook::hddb0e884a202de7c
                               at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/panicking.rs:779:13
  12:        0x1004318a0 - std::panicking::begin_panic_handler::{{closure}}::hd2798398a2fd9077
                               at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/panicking.rs:657:13
  13:        0x100430784 - std::sys_common::backtrace::__rust_end_short_backtrace::h9201cc364dbb8a23
                               at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/sys_common/backtrace.rs:170:18
  14:        0x10043163c - rust_begin_unwind
                               at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/panicking.rs:645:5
  15:        0x100453300 - core::panicking::panic_fmt::h4d5168028d4c43c7
                               at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/core/src/panicking.rs:72:14
  16:        0x100453620 - core::result::unwrap_failed::hc60ef978ea39e1b4
                               at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/core/src/result.rs:1653:5
  17:        0x1003bc010 - cargo_sort::sort::sort_toml::h287b7948373ee1d2
  18:        0x1003c1cc0 - cargo_sort::_main::hb37f42d91bf850c3
  19:        0x1003c32f8 - cargo_sort::main::h8cda5f33043fdf6c

@joao-conde
Copy link

Is this being worked on? Can I tackle it?

nipunn1313 added a commit to nipunn1313/cargo-sort that referenced this issue Aug 7, 2024
@nipunn1313
Sort workspace dependencies
425adb0 
Part of the new workspace dependencies feature described here
https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#inheriting-a-dependency-from-a-workspace

Fixes DevinR528#54
@johnyob johnyob mentioned this issue Aug 15, 2024
Merged
@hoijui
Copy link

hoijui commented Oct 14, 2024

This has already two PRs that fix it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sort workspace dependencies nipunn1313/cargo-sort
5 participants
@hoijui @extrawurst @eirenik0 @nipunn1313 @joao-conde