From c8f7061bdd9cca0c0bb8ba6ec482fd176a987526 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?marker=20dao=20=C2=AE?= Date: Wed, 9 Oct 2024 12:33:31 +0200 Subject: [PATCH] refactor(lookup): Rename tests --- .../DevExpress.ui.widgets.editors/lookup.tests.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/lookup.tests.js b/packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/lookup.tests.js index 5070a48c6912..cf50c460288b 100644 --- a/packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/lookup.tests.js +++ b/packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/lookup.tests.js @@ -2175,7 +2175,7 @@ QUnit.module('popup options', { assert.equal($overlay.is(':visible'), false, 'overlay is hidden'); }); - QUnit.test('lookup popup should not be hidden after click outside was present', function(assert) { + QUnit.test('lookup popup should not be hidden after click outside was present if dropDownOptions.hideOnOutsideClick is set to false', function(assert) { const $lookup = $('#lookupOptions'); const instance = $lookup.dxLookup({ 'dropDownOptions.hideOnOutsideClick': false, @@ -2206,7 +2206,7 @@ QUnit.module('popup options', { const popup = usePopover ? PopoverFull.getInstance($overlay) : PopupFull.getInstance($overlay); const { _loopFocus } = popup.option(); - assert.equal(_loopFocus, !usePopover); + assert.strictEqual(_loopFocus, !usePopover, '_loopFocus is correct'); }); }); @@ -2950,7 +2950,7 @@ QUnit.module('keyboard navigation', { assert.ok(instance.option('opened'), 'popup is opened'); }); - QUnit.test('focus from first Popover element should move back to Lookup field while keeping Popup open when usePopover: true', function(assert) { + QUnit.test('focus from first Popover element should move back to Lookup field while keeping Popup open when usePopover: true and shift+Tab is pressed', function(assert) { if(devices.real().deviceType !== 'desktop') { assert.ok(true, 'test does not actual for mobile devices'); return; @@ -2962,11 +2962,11 @@ QUnit.module('keyboard navigation', { focusStateEnabled: true, }); const instance = $element.dxLookup('instance'); - const tabKeyDownEvent = $.Event('keydown', { key: 'Tab', shiftKey: true }); + const shiftTabKeyDownEvent = $.Event('keydown', { key: 'Tab', shiftKey: true }); const $overlayContent = $(instance.content()).parent(); const $searchInput = $overlayContent.find(`.${LOOKUP_SEARCH_CLASS} .${TEXTEDITOR_INPUT_CLASS}`); - $searchInput.trigger(tabKeyDownEvent); + $searchInput.trigger(shiftTabKeyDownEvent); assert.ok($element.hasClass(FOCUSED_CLASS), 'lookup field is focused'); assert.ok(instance.option('opened'), 'popup is opened');