Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Choice of fixed parameter is ignored in pade_lstsq #31

Open
DerWeh opened this issue May 1, 2022 · 0 comments
Open

Choice of fixed parameter is ignored in pade_lstsq #31

DerWeh opened this issue May 1, 2022 · 0 comments

Comments

@DerWeh
Copy link
Owner

DerWeh commented May 1, 2022

The implementation of pade_lstsq is incorrect, as the value of fix_q is ignored, see lgtm.

The current heuristic, however, doesn't pass the tests. Which parameter is fixed played a significant role for the accuracy of the Pade-Fourier results.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DerWeh