Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cyclonedx json media type when exporting components #4409

Merged

Conversation

wratner
Copy link
Contributor

@wratner wratner commented Nov 25, 2024

Description

This allows the /v1/bom/cyclonedx/component/{uuid} endpoint to accept the application/vnd.cyclonedx+json media type just as the /v1/bom/cyclonedx/project/{uuid} endpoint does.

Addressed Issue

Fixes #4408

Additional Details

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@wratner wratner force-pushed the bug/export-component-json-media-type branch 2 times, most recently from 41602c8 to 109876e Compare November 25, 2024 21:00
@wratner wratner marked this pull request as draft November 25, 2024 21:01
Signed-off-by: Will Ratner <Will Ratner>
Signed-off-by: Will Ratner <[email protected]>
@wratner wratner force-pushed the bug/export-component-json-media-type branch from 109876e to b078070 Compare November 25, 2024 21:21
@wratner wratner marked this pull request as ready for review November 25, 2024 21:22
@nscuro nscuro added this to the 4.13 milestone Nov 26, 2024
@nscuro nscuro added defect Something isn't working backport/4.12.2 PRs to be backported to version 4.12.2 labels Nov 26, 2024
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ea002e9) 22581 17875 79.16%
Head commit (b078070) 22581 (+0) 17875 (+0) 79.16% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4409) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro nscuro merged commit 193d0f9 into DependencyTrack:master Nov 26, 2024
11 checks passed
@wratner wratner deleted the bug/export-component-json-media-type branch November 26, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/4.12.2 PRs to be backported to version 4.12.2 defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BOM component API Incompatibility with application/vnd.cyclonedx+json Media Type
2 participants