Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced Model Sampling #3

Open
Mol31 opened this issue Oct 18, 2024 · 6 comments
Open

Advanced Model Sampling #3

Mol31 opened this issue Oct 18, 2024 · 6 comments

Comments

@Mol31
Copy link

Mol31 commented Oct 18, 2024

Thank you for your hard work on mainline Forge and this extension.

With the new developments in local AI models, there is a shift towards Vpred, ZSNR-trained models.
Is it possible for this extension to adapt Advanced Model Sampling from the Reforge fork?

Many thanks for considering my request.

@DenOfEquity
Copy link
Owner

Looking at the reforge AMS builtin extension, it is based on ldm_patched (comfy) code which was completely stripped out in lllyasviel's forge2 update. The missing parts seem to be:

  • zero-terminal snr sigmas, which forge2 has a setting for. Though I'm not sure how effective it is, so this should be looked at. Simply copying over the function and applying it to the sigmas does not work.
  • rescaleCFG, which is included in the LatentModifer Integrated extension, as Rescale Cfg Phi (the slider has much too high a range, typical best value is around 0.7)
  • (maybe) allowing relatively very high sigma_max, which can be set in the Settings; the allowed range probably needs to be increased. Though not all schedulers use that setting, the older ones do.

@Enferlain
Copy link

Enferlain commented Oct 20, 2024

k_prediction.py seems to have has stuff pertaining to v-pred, edm, epsilon etc (and now ztsnr) but for some reason I can't get cosxl to work even if I try selecting it in your extension, weird

I did confirm v-pred works though so that's nice

@Enferlain
Copy link

@Enferlain
Copy link

@DenOfEquity any idea of it's possible to enable the vpred setting from this extension through txt2img API calls?

@DenOfEquity
Copy link
Owner

I don't use API, so not sure. But maybe add to the payload:
"alwayson_scripts": {"Forge2 extras": {"args": [True, 0,0,0,0, 'v_prediction']}}

@Enferlain
Copy link

actually worked, goat
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants