Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow detecting nodes with degree 4 that should still be simplified #557

Open
sahand-asgarpour opened this issue Aug 16, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request Launch
Milestone

Comments

@sahand-asgarpour
Copy link
Contributor

Kind of request

Adding new functionality

Enhancement Description

graph_complex.edges = [(0,1), (1,2), (1, 0), (2, 1)] => graph_simplified.edges = [(0, 2), (2, 0)]

Right now it graph_simplified.edges = [(0,1), (1,2), (1, 0), (2, 1)]

So we should allow detecting nodes with degree 4 that should still be simplified. Right now nodes with degree 2 will be detected for simplification which misses the cases explained above.

Use case

No response

Additional Context

No response

@sahand-asgarpour sahand-asgarpour added enhancement New feature or request Launch labels Aug 16, 2024
@sahand-asgarpour sahand-asgarpour self-assigned this Aug 16, 2024
@sahand-asgarpour sahand-asgarpour added this to the Launch 2024 milestone Sep 4, 2024
sahand-asgarpour added a commit that referenced this issue Sep 16, 2024
…ed (#560)

## Issue addressed
Solves #557 

## Code of conduct
- [x] I HAVE NOT added sensitive or compromised (test) data to the
repository.
- [x] I HAVE NOT added vulnerabilities to the repository.
- [x] I HAVE discussed my solution with (other) members of the RA2CE
team.

## What has been done?
Explain how you addressed the resolution of the related issue, what
choices you made and why.

### Checklist
- [ ] Code is formatted using our custom `black` and `isort`
definitions.
- [x] Tests are either added or updated.
- [x] Branch is up to date with `master`.
- [x] Updated documentation if needed.

## Additional Notes (optional)
Add any additional notes or information that may be helpful.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Launch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant