Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace branches/find_nearest_branch() #5

Closed
rhutten opened this issue Jun 23, 2023 · 1 comment · Fixed by #74
Closed

Replace branches/find_nearest_branch() #5

rhutten opened this issue Jun 23, 2023 · 1 comment · Fixed by #74
Assignees

Comments

@rhutten
Copy link
Collaborator

rhutten commented Jun 23, 2023

What is the need for this task.
We are now using a copied version of the find_nearest_branch() method of D-HyDAMO. This should change.

What is the task?
Execute the steps bellow:

  • Investigate HydroMT nearest join function --> how we could replace the overal, intersect and ends method from find_nearest_branch().
  • Implement the function into plugin
  • Test if it works properly and replaces D-HyDAMO function: propose generate the model with D-HyDAMO function and with updated nearest join function. Check the difference in input files.

Decisions

  • For the ends method, so line ends snapped to another line, like culverts, we decided that for the first release we will not adopt this method. We assume that culverts are for now points and we do not have setup culverts.
@rhutten rhutten assigned rhutten and xldeltares and unassigned rhutten Aug 11, 2023
xldeltares added a commit that referenced this issue Aug 25, 2023
@xldeltares xldeltares linked a pull request Aug 25, 2023 that will close this issue
5 tasks
@xldeltares
Copy link
Collaborator

Function is complete but due to precision differences, the tests keep failing.

Proposed solution after discussion with Hélène:
in write geoms, write the geojson with certain percision. additional benefit: smaller size geojson.

Reopen the issue and describe how this could have influenced test results due to precision More efficient JSON in staticgeoms · Issue #30 · Deltares/hydromt (github.com)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants