Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert incorrect hydrolib-core expected values #148

Open
2 of 7 tasks
veenstrajelmer opened this issue Sep 25, 2024 · 0 comments
Open
2 of 7 tasks

Revert incorrect hydrolib-core expected values #148

veenstrajelmer opened this issue Sep 25, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Sep 25, 2024

Version checks

  • I have checked that this issue has not already been reported.
  • I have checked that this bug exists on the latest version.

Description

In #139 some mdu keywords were updated to new values.

Were empty before:

dzTop                      = -999                                                           # Z-layer thickness of layers above level Dztopuniabovez
floorLevTopLay             = -999                                                           # Floor level of top layer
dzTopUniAboveZ             = -999                                                           # Above this level layers will have uniform dzTop, below we use sigmaGrowthFactor
bgrwuni                  = -999     # uniform level of impervious layer, only used if h_aquiferuni is negative.
sgrwini                  = -999 # Initial groundwater level, if h_unsatini < 0.
trtDef = .    # File (*.ttd) including trachytope definitions.
trtL   = .    # File (*.arl) including distribution of trachytope definitions.
outputDir                         = .      # Output directory of map-, his-, rst-, dat- and timingsfiles, default: DFM_OUTPUT_<modelname>. Set to . for no dir/current dir.
waqOutputDir                      = .      # Output directory of Water Quality files.

Not existent before:

fixedWeirTopFrictCoef = -999 # Uniform friction coefficient of the groyne part of fixed weirs [the unit depends on frictiontype].

Especially the . values are not expected, these might cause issues and they might not. This has been reported in hydrolib-core.

Todo:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant