Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metadata without macros #432

Open
verseve opened this issue Jun 20, 2024 · 0 comments · Fixed by #434 · May be fixed by #489
Open

Metadata without macros #432

verseve opened this issue Jun 20, 2024 · 0 comments · Fixed by #434 · May be fixed by #489
Assignees
@verseve
Labels
v1.0 Activities related to v1.0

Comments

@verseve
Copy link
Member

verseve commented Jun 20, 2024

Feature type

Changing existing functionality

Improvement Description

The metadata of struct fields is generated with macros. While fancy, it is not very readable/explicit (code), and it is only used for model coupling through BMI and thus not exposed to a wflow user (running a wflow model simulation). Implementing metadata without macros makes the code more readable/explicit.

Implementation Description

No response

Additional Context

No response
@verseve verseve added the v1.0 Activities related to v1.0 label Jun 20, 2024
@verseve verseve self-assigned this Jun 20, 2024
@verseve verseve mentioned this issue Jun 26, 2024
Merged
@verseve verseve linked a pull request Jun 26, 2024 that will close this issue
Cleanup metadata macros #434
Merged
@SouthEndMusic SouthEndMusic linked a pull request Oct 23, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@verseve verseve

Labels
v1.0 Activities related to v1.0
Projects
None yet
Milestone
No milestone
1 participant
@verseve