-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Average flow states #1906
Comments
In this formulation, the total flow over an edge over the latest timestep is given by |
When a node has a flow between and so |
Github mobile has no math support, so this issue was completely unreadable. On desktop though, this seems like an interesting experiment. It's part of the normalization approach, but nice thought to be doing so over time instead of relating it to total flow or similar. My main concerns are 1, we should improve our benchmarks suite first, otherwise these investigations are not that efficient. 2 would be readability, but I assume we can hide the |
Seems like a good idea to try out. I guess we'd be able to keep the cumulative BMI variables around and just calculate them on the spot. |
A better formulation of the states might be where
What it essentially computes is the average flow as if there was a period of length Which gives the DE In this formulation, the total flow over an edge over the latest timestep is given by Bounding the cumulative flow yields and so |
Now we define a state like this:
which is increasing with time for most node types. So what if instead we define states like this:
which is almost the same as the average of the flow rate since the start of the simulation. The$+1$ in the denominator is just there to avoid division problems at the start of the simulation.
The differential equation for a state is then, using that the cumulative flow is given by$(t - t_0 + 1)u$ ,
or in$u'= f(u,p,t)$ form
This might introduce different accuracy problems, but it's worth an experiment. This would be a fix of #1897, in combination with #1904.
The text was updated successfully, but these errors were encountered: