Refactor of concentration code #1929
Open
+302
−248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SouthEndMusic
commented
Nov 11, 2024
docs/guide/delwaq.ipynb
Outdated
evetion
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
I had my doubts about this refactor because it now becomes a separate callback, and I thought that cumulative flow was updating some states that we also needed for concentrations, but that doesn't seem to be the case. Let's merge the other PR, retest here, and then merge.
visr
added a commit
that referenced
this pull request
Nov 14, 2024
Ideally we merge this before #1933 and #1929, so we know they don't break anything. --------- Co-authored-by: Martijn Visser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1905