Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of OrdinaryDiffEq internals usage #1778

Open
SouthEndMusic opened this issue Aug 29, 2024 · 0 comments · May be fixed by #1784
Open

Get rid of OrdinaryDiffEq internals usage #1778

SouthEndMusic opened this issue Aug 29, 2024 · 0 comments · May be fixed by #1784
Labels
core Issues related to the computational core in Julia tech-debt Improvements related to technical debt

Comments

@SouthEndMusic
Copy link
Collaborator

#1761 introduced the function residual which makes use of OrdinaryDiffEq internals. This should be removed when possible, probably when the upstream issue is fixed: SciML/OrdinaryDiffEq.jl#2442.
@SouthEndMusic SouthEndMusic added core Issues related to the computational core in Julia tech-debt Improvements related to technical debt labels Aug 29, 2024
@github-project-automation github-project-automation bot moved this to To do in Ribasim Aug 29, 2024
@SouthEndMusic SouthEndMusic changed the title Get rid of function residual Get rid of OrdinaryDiffEq internals usage Aug 29, 2024
@SouthEndMusic SouthEndMusic linked a pull request Sep 2, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Issues related to the computational core in Julia tech-debt Improvements related to technical debt
Projects
Ribasim
Status: To do
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove OrdinaryDiffEq internals Deltares/Ribasim
1 participant
@SouthEndMusic