New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generic model utilities and validators (from Ribasim-NL) #1739

Open

evetion opened this issue Aug 20, 2024 · 0 comments

Labels

validation

Member

evetion commented Aug 20, 2024

To be downstreamed from Deltares/Ribasim-NL#129

remove_node remove a node, possibility to remove connected_edges as well
remove_edge: remove an edge, possibility to remove disconnected_nodes as well
reverse_edge: reverse an edge and it's from and to properties

I'd also copy (via templating ideally) some validation from Julia to Python:

Allowed node neighbors
Number of neighbors

Some more validation on geometries

Edge geometry requires begin/end to match with nodes
Basin/area geometry requires to intersect with the basin node

Furthermore I can imagine we error on creating, and on writing, but allow for reading a model into memory, but give a warning?

github-project-automation bot added this to Ribasim

github-project-automation bot moved this to To do in Ribasim

evetion added the validation label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment