Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on large water balance error #1413

Closed
visr opened this issue Apr 22, 2024 · 3 comments
Closed

Error on large water balance error #1413

visr opened this issue Apr 22, 2024 · 3 comments
Assignees
Labels
core Issues related to the computational core in Julia performance Relates to runtime performance or convergence v1.0 Release!

Comments

@visr
Copy link
Member

visr commented Apr 22, 2024

What
If the water balance error exceeds a certain fraction, we want the simulation to stop with a clear error message.

How
We should probably add a solver option for this with a reasonable default fraction like 0.01.

Additional context

@visr visr added the core Issues related to the computational core in Julia label Apr 22, 2024
@github-project-automation github-project-automation bot moved this to To do in Ribasim Apr 22, 2024
@visr visr added the performance Relates to runtime performance or convergence label May 17, 2024
@visr visr added the v1.0 Release! label Aug 8, 2024
@evetion
Copy link
Member

evetion commented Aug 15, 2024

We could consider implementing a continuity tracer for this (which gives a fraction around 1 per basin?) as well during the run?

Or did you plan on moving the logic in #1367 to a callback?

@visr
Copy link
Member Author

visr commented Aug 15, 2024

Yeah the latter.

@visr
Copy link
Member Author

visr commented Sep 23, 2024

Done in #1819, in the function check_water_balance_error.

@visr visr closed this as completed Sep 23, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Ribasim Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues related to the computational core in Julia performance Relates to runtime performance or convergence v1.0 Release!
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants