Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover_layer_thickness is not generic #4

Open
Erik-Geo opened this issue Mar 7, 2024 · 0 comments
Open

Cover_layer_thickness is not generic #4

Erik-Geo opened this issue Mar 7, 2024 · 0 comments
Labels
invalid This doesn't seem right

Comments

@Erik-Geo
Copy link
Collaborator

Erik-Geo commented Mar 7, 2024

The method "cover_layer_thickness" in BoreholeCollection (see module: https://github.com/Deltares-research/geost/blob/main/geost/borehole.py) is not generic as it expect NEN5104 lithologies only.

Options:

  • Make generic by forcing the user to define what lithologies are associated with the cover layer and non-cover layer
  • Remove altogether!
@Erik-Geo Erik-Geo added the invalid This doesn't seem right label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant