Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary dataframe copies in methods #24

Open
Erik-Geo opened this issue Aug 20, 2024 · 0 comments
Open

Remove unnecessary dataframe copies in methods #24

Erik-Geo opened this issue Aug 20, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Erik-Geo
Copy link
Collaborator

Erik-Geo commented Aug 20, 2024

In LayeredData.select_by_values, the copy operation is really slow on large datasets (e.g. DINO, 5 million rows):

selected = self.df.copy()

However, this also works as intended and doesn't slow down the select_by_values operation:

selected = self.df

See where we can optimize other methods by removing unnecessary copies and make sure that we test dataframe copy/view behaviour.

@Erik-Geo Erik-Geo added the enhancement New feature or request label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant