Harpy Bugs #180
Comments
|
Merged
luringens
added a commit
to luringens/Delta-v-rebase
that referenced
this issue
Oct 24, 2023
Stops harpies from opening the MIDI UI while muzzled. Also reworks how harpies are stopped from singing when incapacitated, so that harpies are allowed to sing while cuffed. And for UX sake, tells the player why they can't sing when applicable. This should fix some of DeltaV-Station#180.
DebugOk
added a commit
that referenced
this issue
Oct 27, 2023
* Stop singing when muzzled * Changes to when harpies can sing Stops harpies from opening the MIDI UI while muzzled. Also reworks how harpies are stopped from singing when incapacitated, so that harpies are allowed to sing while cuffed. And for UX sake, tells the player why they can't sing when applicable. This should fix some of #180. * Refactor to remove SingerIncapacitatedEvent * Significantly clean up HarpySingerComponent * Do not allow singing while zombified, also refactoring * Additional singing conditions Now stops singing if knocked down, stunned, or asleep. Also prevents singing if the player for any reason can not talk. * Stop singing when muted status effect is applied * Damage interrupts harpies when singing * Rename cantSpeak to canNotSpeak * Remove most cant-sing explanations * Change can-not-sing feedback message Co-authored-by: Debug <[email protected]> Signed-off-by: Bakke <[email protected]> --------- Signed-off-by: Bakke <[email protected]> Co-authored-by: Debug <[email protected]>
LaryNevesPR
pushed a commit
to LaryNevesPR/Estacao-Andromeda
that referenced
this issue
Jan 3, 2025
…tation#180) ## Mirror of PR #25661: [Fix Butcherable handling, ItemSlots for clown shoes](space-wizards/space-station-14#25661) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `674b42b3a0ab9fa607887c1401f38ca1f8bb3911` PR opened by <img src="https://avatars.githubusercontent.com/u/42424291?v=4" width="16"/><a href="https://github.com/Krunklehorn"> Krunklehorn</a> at 2024-02-28 02:04:52 UTC --- PR changed 9 files with 75 additions and 30 deletions. The PR had the following labels: - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > ## About the PR > > - Fixes improper popups with edible+butcherable items, and sharp+utensil items > - Clown shoes have item slots > - Intended for non-harmful items other than their job specific gun > - Currently supports plastic knives, cap gun & fake cap gun > > Minor stuff... > - Spoons are metal > - Plastic knives are actually plastic knives > - Plastic utensils are now zero damage weapons > - Raw rat meat is sliceable > > > ## Why / Balance > > Funny suggestion, but also a legitimate way for a Clown to sneak their job specific gun into a holding cell/perma. > > > ## Media > > - [X] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > > **Changelog** > > :cl: Krunk > - add: Clown & Jester shoes can now hold plastic knives and cap guns! All clowning, all the time! > </details> Co-authored-by: SimpleStation14 <Unknown>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm going to write this issue here because it's not really something I have the skill to address, and Harpies are spread across multiple PRs due to the scope anyway. In this case Major bugs are significantly gamebreaking, while their minor bugs are just inintended things that may annoy players(or me as their creator).
Major Bugs
Therefore if you kill a harpy while they are singing, they will continue to sing even while dead. I've partially fixed this in #175, but my fix only addressed them being able to open the menu while dead.
Minor Bugs
The text was updated successfully, but these errors were encountered: