You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the aggregator circuits' vkey is convergent for recursive aggregation. (The vkey can be the same after the 2nd aggregation).
There is a corner case that may delay the convergent point when constant dedup is enabled. It is caused by different dedup positions (between the 2nd aggregation and 3rd aggregation), and results in the change of permutation and constant value hash size.
I won't fix it soon, because it is not a security bug and the circuit size would be slightly larger without dedup. But if anyone suffers from this issue, we can fix it by removing the dedup.
lanbones
changed the title
Constant dedup may break circuit vkey convergence for recursive aggregation
Constant value dedup may delay circuit vkey convergence point for recursive aggregation
Jul 3, 2024
Currently, the aggregator circuits' vkey is convergent for recursive aggregation. (The vkey can be the same after the 2nd aggregation).
There is a corner case that may delay the convergent point when constant dedup is enabled. It is caused by different dedup positions (between the 2nd aggregation and 3rd aggregation), and results in the change of permutation and constant value hash size.
I won't fix it soon, because it is not a security bug and the circuit size would be slightly larger without dedup. But if anyone suffers from this issue, we can fix it by removing the dedup.
halo2aggregator-s/src/api/ast_eval.rs
Lines 279 to 286 in 00829f5
halo2aggregator-s/src/api/ast_eval.rs
Lines 191 to 198 in 00829f5
The text was updated successfully, but these errors were encountered: