Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented collect overloads Base.collect #4

Open
ThatDezKnightGuy opened this issue Mar 15, 2023 · 1 comment
Open

Implemented collect overloads Base.collect #4

ThatDezKnightGuy opened this issue Mar 15, 2023 · 1 comment

Comments

@ThatDezKnightGuy
Copy link

image

The provided PromClient collect function overloads the Base collect function Base.collect as it is exported. This is causing issues when I try and run unit tests w

Is collect supposed to be exported and used? Or should it be changed to not export and be noted as a private _collect function?
@ThatDezKnightGuy
Copy link
Author

Or, should it be a dispatch on the type, eg. Base.collect(x)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ThatDezKnightGuy