Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge "develop" to "master" and release new NuGet package version #14

Open
davidnguyen opened this issue Dec 1, 2017 · 4 comments
Open

Comments

@davidnguyen
Copy link
Contributor

Hi,
I'm trying to get Atlas to work with Sitecore 9 and it's all well and good except the LinkFieldRenderingString class still has some dependency to CommonServiceLocator. In Sitecore 9, CommonServiceLocator is still used, but reserved for Solr integration only. This breaks on any ViewModel class that uses ILinkFieldRenderingString. The fix for this has already merge to the "develop" branch. It would be great if it could be merged to master, and release a new version of NuGet package.

Thanks,
David Nguyen

@heikof
Copy link
Collaborator

heikof commented Dec 6, 2017

Hi @davidnguyen - which change on the develop branch are you referring to? Or do you mean pull request #13 ?

@geekrocket
Copy link
Collaborator

Previous fixes (not including DI) have been merged and tagged as v1.0.1, with the final DI changes being pulled through from PR #13 to PR #16 (pending review) which will go out as v1.1.0 - with Sitecore 8.2 being the minimum version required.

@davidnguyen
Copy link
Contributor Author

@heikof @geekrocket thanks guys, can you let me know when the new NuGet package v1.0.1, or v1.1.0 can be released?

@davidnguyen
Copy link
Contributor Author

@geekrocket can we do a NuGet package release on the latest code mate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants