Be sane with checking messageLen in SHA modules

Dekkonot · Oct 1, 2023 · 190b9dc · 190b9dc
1 parent 0c924cb
commit 190b9dc
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/modules/sha1/init.luau b/modules/sha1/init.luau
@@ -95,7 +95,7 @@ local function sha1(message: string): (string, { number })
 
 	local messageLen = #message
 	local leftover = messageLen % 64
-	if messageLen / 64 >= 1 then
+	if messageLen >= 64 then
 		processBlocks(digest, message, 1, messageLen - leftover)
 	end
 

diff --git a/modules/sha224/init.luau b/modules/sha224/init.luau
@@ -114,7 +114,7 @@ local function sha224(message: string): (string, { number })
 
 	local messageLen = #message
 	local leftover = messageLen % 64
-	if messageLen / 64 > 1 then
+	if messageLen >= 64 then
 		processBlocks(digest, message, 1, messageLen - leftover)
 	end
 

diff --git a/modules/sha256/init.luau b/modules/sha256/init.luau
@@ -114,7 +114,7 @@ local function sha256(message: string): (string, { number })
 
 	local messageLen = #message
 	local leftover = messageLen % 64
-	if messageLen / 64 > 1 then
+	if messageLen >= 64 then
 		processBlocks(digest, message, 1, messageLen - leftover)
 	end
 

diff --git a/modules/sha384/init.luau b/modules/sha384/init.luau
@@ -288,7 +288,7 @@ local function sha384(message: string): string
 
 	-- SHA-384 has a block size of 1024 bits or 128 bytes
 	local leftover = messageLen % 128
-	if messageLen / 128 > 1 then
+	if messageLen >= 128 then
 		processBlocks(digest_front, digest_back, message, 1, messageLen - leftover)
 	end
 	local finalMessage = {

diff --git a/modules/sha512/init.luau b/modules/sha512/init.luau
@@ -288,7 +288,7 @@ local function sha512(message: string): string
 
 	-- SHA-512 has a block size of 1024 bits or 128 bytes
 	local leftover = messageLen % 128
-	if messageLen / 128 > 1 then
+	if messageLen >= 128 then
 		processBlocks(digest_front, digest_back, message, 1, messageLen - leftover)
 	end
 	local finalMessage = {