Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add arguments to service #35

Merged
merged 8 commits into from
Jun 30, 2020

Conversation

DarkChaos
Copy link
Contributor

@DarkChaos DarkChaos commented Jun 18, 2020

Implemented support to set Displayname, Description and StartupType for non TopShelf services.
Fixed Spaces issue in Service name (#28)
Implemented support for Command Arguments Implemented support to install dotnet based Services (Fixes #11)
Fixed Permission issue (add RunAsService Permission while installation)
Added Service removal to CleanInstall

@DarkChaos DarkChaos force-pushed the feature/addArgumentsToService branch from cc1c3c5 to 8c7902a Compare June 19, 2020 13:29
@jamie-railton
Copy link

Any idea when we might see these features pulled?

@Dejulia489
Copy link
Owner

This is great!!

Sorry for the delay, I am in the middle of moving. I should have some time early this coming week to review this more thoroughly.

@DarkChaos
Copy link
Contributor Author

Solves also #36 and #37

@MCrank
Copy link

MCrank commented Jun 30, 2020

I am also looking for these features. Thanks for the PR @DarkChaos and thanks @Dejulia489 for this module overall. Has been a big help.

@Dejulia489 Dejulia489 merged commit 6ebe73f into Dejulia489:master Jun 30, 2020
@Dejulia489
Copy link
Owner

@DarkChaos,

Made the following changes:

  1. Added 'Recreate service' flag to the installation group. This will delete the service if it already exists.
  2. Removed utility and spammed the functions across the DeployWindowsService.ps1 because they need to be available in the script block. That isn't the right way to do it but I had to push a quick fix because the tool was broken.
  3. Updated Clean Install to 'Clean binary install'
  4. Casing on param names.

This has been published to the Marketplace, thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants