Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies with Fees/Revenue endpoints #4168

Open
lgingerich opened this issue Aug 27, 2023 · 0 comments
Open

Inconsistencies with Fees/Revenue endpoints #4168

lgingerich opened this issue Aug 27, 2023 · 0 comments

Comments

@lgingerich
Copy link
Contributor

The summary/fees/{protocol} endpoint has some inconsistencies that I believe should be improved. I have not checked this behavior against the other fees/revenue endpoints, so it may also apply to those.

  1. https://api.llama.fi/summary/fees/ethereum?dataType=dailyFees and https://api.llama.fi/summary/fees/ethereum?dataType=dailyRevenue both work as I would expect, but for dataType=totalFees and dataType=totalRevenue configs, I get a response with both totalDataChart and totalDataChartBreakdown returning null values. Based on the data I see in the dashboard, this shouldn't be the case. For Lyra, dailyFees is the only config that produces non-null results.

  2. Volume endpoints include excludeTotalDataChart and excludeTotalDataChartBreakdown flags. Given that volume and fees/revenue are given in the same format, I believe that the fees/revenue endpoints should include this same behavior even if it has virtually no effect on final usage of this data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@lgingerich and others