Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

including skeleton #3

Closed
bendichter opened this issue Oct 15, 2021 · 5 comments · Fixed by #7
Closed

including skeleton #3

bendichter opened this issue Oct 15, 2021 · 5 comments · Fixed by #7
Assignees
Labels
enhancement New feature or request

Comments

@bendichter
Copy link
Contributor

bendichter commented Oct 15, 2021

ndx-pose has a place for "edges", which I think maps to "skeleton" in DLC. However, the example config.yml does not contain skeleton information and the converter does not handle skeleton info. Including this information would allow us to provide much better visualizations of DLC output in NWB Widgets.

@AlexEMG
Copy link
Member

AlexEMG commented Oct 17, 2021

Good point. Skeleton can have two roles in DLC:

  • for visualization (in the provided example it wasn't populated)
  • for inference in the case of multiple animals, in which case it is functionally important (see Lauer et al.).

We should probably distinguish those cases. In general right now we are not putting much metadata from the DLC model that makes the predictions into the NWB file. Perhaps it would be best to also provide the relevant entries from pose-cfg.yaml.

@AlexEMG AlexEMG added the enhancement New feature or request label Oct 17, 2021
@bendichter
Copy link
Contributor Author

@AlexEMG how would you want to distinguish between these cases? What other types of data are in pose-cfg.yml that you think might be useful here?

@AlexEMG
Copy link
Member

AlexEMG commented Oct 20, 2021

Depends on the philosophy. The most extreme case is having all metadata to document how the data was created; the minimalist version could be just the network name (scorer name as it is already included)

What are the essential values to store to understand the dataset and the process by which the dataset was produced?

For a given project, this metadata is likely going to be identical and could be put in a central NWB project file? On the other hand, the metadata is relatively small to store and could go with each video's output.

For the skeleton file,

  • if it is used for inference, then I feel it should go into the metadata outlined above
  • if it is for the sake of visualizing in NWB (or other downstream applications), then we could maybe give a specialized name? E.g. 'visualization_skeleton'

@AlexEMG
Copy link
Member

AlexEMG commented Oct 20, 2021

Opened this issue more towards general metadata: #4

@AlexEMG
Copy link
Member

AlexEMG commented Dec 9, 2021

The skeleton is now in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants