Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download Task does not add new strings #10

Open
jakobulbrich opened this issue Feb 3, 2022 · 1 comment
Open

Download Task does not add new strings #10

jakobulbrich opened this issue Feb 3, 2022 · 1 comment

Comments

@jakobulbrich
Copy link

I encountered several issues when trying to download strings.

  1. When starting completely clean without any strings.xml file, executing phraseappDownload will fail complaining about a missing strings.xml file. I didn't expect that I need a default file to be able to execute the download task.
  2. When I create the needed strings.xml file, leave it empty and execute phraseappDownload it will create the remaining strings.xmlfiles per language but leaves everything empty.
  3. When I add a string to all of my strings.xml files, the download task will correctly update the values, but it does not add new strings from phrase.

I expected that the download task will automatically add and update strings from phrase.

@adrienbusin
Copy link
Contributor

Hello @jakobulbrich sorry for the delay, I will take the lead from today on this project.

  1. What is the behavior you expected ? We download resources from phrase, and after that we tried to write them on your files. If you don't have a strings.xml, how can we write on it ?
  2. The task leave them empty if there is no traduction found for these languages on phrase. Your app will use default instead. What is your behavior you expected ?
  3. If you want to add new strings on phrase, you should use phraseappUpload

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants