Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel orders functionality not working correctly #592

Open
fliebenberg opened this issue Oct 11, 2024 · 1 comment
Open

Cancel orders functionality not working correctly #592

fliebenberg opened this issue Oct 11, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@fliebenberg
Copy link
Contributor

When I select an order to cancel in one pair, it shows "Cancel 1 Order" in red at the top of the column.
image
When I then navigate to another pair, the red "Cancel 1 Order" is still displayed although I am now in a different pair with different open orders displayed - none of which are selected. If I now select an order here as well it will show "Cancel 2 orders" even though I am only seeing one order selected for the pair.
If I now navigate back to pair 1, it still shows "Cancel 2 orders" but it now shows no orders selected, not even the one I had selected previously. When I select that order again, it shows as selected but does not increase the count again.

I think we should make it that selected orders are reset every time the user changes pairs. So batch cancel should only work for one pair. In fact it will only work for one pair as cancel tx needs to specify a specific pair component.

@fliebenberg fliebenberg added the bug Something isn't working label Oct 11, 2024
@yuliaSharabi
Copy link
Contributor

Does it works same way if the toggle of "hide other pairs" is on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

2 participants