Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatch on Trades text in pair Xraw/xrd - 2 BUY orders but appears also "No Trades have occured yet" #589

Open
yuliaSharabi opened this issue Oct 1, 2024 · 5 comments

Comments

@yuliaSharabi
Copy link
Contributor

On the Trades book on the left it appears "No trades have occurred yet" but there is 2 BUY orders at the moment.
image

@yuliaSharabi
Copy link
Contributor Author

@dcts @fliebenberg Any thoughts on the matter?

@fliebenberg
Copy link
Contributor

This is probably correct. It means even though there are 2 buy orders available, no one has wanted to sell at those prices. So there have been no trades in the pair yet, even though there are open orders.

@yuliaSharabi
Copy link
Contributor Author

Then why the behaviour is inconsisten over other pairs?
@fliebenberg
Example - DFP2/XRD:
No Buy, Just Sell, but the "No trades occured yet" text is not appearing in this case.
image

DGC/XRD pair: opposite example, Sell, no Buy. No Trades text isn't there too.
image

@dcts
Copy link
Contributor

dcts commented Oct 8, 2024

I dont see inconcistency. Theres the following scenarios:

  • did trades happen in the past -> yes/no. If "no" we show "no trades have occured yet"
  • are there buy orders on the orderbook -> if "no" we show "no open buy orders"
  • are there sell orders on the orderbook -> if "no" we show "no open sell orders".

All 3 things are independant of each other. So you could have all 3 messages, or only 2 or 1 or none of them.

@yuliaSharabi
Copy link
Contributor Author

If both DFP2/XRD and Xraw/xrd has sell orders. Why on one of them there is Trades and on the other there isn't?

Maybe I do not understand what you consider a Trade. But if there is someone selling then there should be also a buy order in order for the text of the trades not to appear?
I am confused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

3 participants