Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Account History more intuitive #447

Open
2 tasks
dcts opened this issue Jun 7, 2024 · 0 comments
Open
2 tasks

Make Account History more intuitive #447

dcts opened this issue Jun 7, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@dcts
Copy link
Contributor

dcts commented Jun 7, 2024

Currently we show in the open orders the specified token in the "Amount" and "Filled quantity".

I think it would be more intuitive to always show the token1 e.g. (on the DEXTR/XRD pair):

  • BUY orders: show DEXTR to buy
  • SELL orders: show DEXTR to sell

Open orders are always LIMIT orders, as MARKER orders will never be "open".

This would involve:

  • calculating the DEXTR filled by using the %filled metric in all cases where token2 was specified.
  •  we should also rename "Amount" in "Quantity", as token1 is always refered to as "Quantity" (while token2 is referred to as "Total"). This will add consistency to the UI as the order input component also uses this terminology.

Currently if you have multiple limit orders and specified a few in DEXTR, and a few in XRD, it will look confusing, like here:

Bildschirmfoto 2024-06-07 um 07 23 07

#accounthistory

@dcts dcts added the enhancement New feature or request label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

1 participant