Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend to user-installable app #432

Closed
kevinlul opened this issue Mar 22, 2024 · 12 comments
Closed

Extend to user-installable app #432

kevinlul opened this issue Mar 22, 2024 · 12 comments

Comments

@kevinlul
Copy link
Contributor

On March 18, Discord announced that user-installed apps are in preview, whereas apps used to be installed on servers. This means we may be able to bring some Bastion interactions, e.g. Slash Commands, to direct messages, including group direct messages.

https://discord.com/developers/docs/tutorials/developing-a-user-installable-app
https://discord.com/developers/docs/change-log#userinstallable-apps-preview

@kevinlul
Copy link
Contributor Author

kevinlul commented Jun 4, 2024

@kevinlul
Copy link
Contributor Author

@kevinlul kevinlul changed the title Investigate viability of extending to user-installable app Extend to user-installable app Jun 11, 2024
@kevinlul
Copy link
Contributor Author

User-installed apps reached general availability https://discord.com/developers/docs/change-log#userinstalled-apps-general-availability

This task will be the next priority after Rush Duel search is released in #468

@kevinlul kevinlul pinned this issue Jun 28, 2024
@kevinlul
Copy link
Contributor Author

Note: due to no discord.js release, user-installable apps are not yet supported by the framework.

@kevinlul kevinlul unpinned this issue Jul 28, 2024
@kevinlul
Copy link
Contributor Author

kevinlul commented Sep 2, 2024

Support introduced in 14.16.0

@kevinlul kevinlul pinned this issue Sep 2, 2024
kevinlul added a commit that referenced this issue Sep 3, 2024
@kevinlul
Copy link
Contributor Author

kevinlul commented Sep 3, 2024

Commands not using custom emojis could be immediately ported:

  • /art
  • /deck
  • /help
  • /id
  • /link
  • /locale (an alternate version is probably better because the options do not make sense)
  • /metagame
  • /ping
  • /price
  • /ygoprodeck
  • /yugipedia

Commands using custom emoji that probably need app emojis to render correctly:

  • /search
  • /rush-duel

kevinlul added a commit that referenced this issue Sep 3, 2024
…506)

Server-specific emojis do not work in the user-install context

#432
@kevinlul
Copy link
Contributor Author

kevinlul commented Sep 3, 2024

🚀 🚀 🚀

@kevinlul
Copy link
Contributor Author

Need to account for server scenarios where the response MUST be ephemeral.

@kevinlul
Copy link
Contributor Author

kevinlul commented Oct 1, 2024

Summary of current launch blockers:

  • Custom emoji do not work. Filter out all emojis from affected commands in the user-install context for now. App emojis can be implemented as follow-up.
  • Server permissions have not been considered. In some cases, the command response must be ephemeral.
  • How default locale will be determined and configured for user-installed commands have not been considered.

@kevinlul
Copy link
Contributor Author

kevinlul commented Nov 3, 2024

Server permissions do not need to be considered. Discord will force the embed to be ephemeral.
image

@kevinlul
Copy link
Contributor Author

kevinlul commented Nov 3, 2024

Update description and all description localizations to distinguish the user-install from the server-specific one.

@kevinlul
Copy link
Contributor Author

kevinlul commented Nov 3, 2024

(this is only needed in development, which uses different server-specific vs user-installed commands)

kevinlul added a commit that referenced this issue Nov 11, 2024
…skip test]

Main purpose: record approximate_guild_count and approximate_user_install_count #432
@kevinlul kevinlul unpinned this issue Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant