Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue on pre-lollipop #1

Open
ZacSweers opened this issue Dec 21, 2015 · 6 comments
Open

Issue on pre-lollipop #1

ZacSweers opened this issue Dec 21, 2015 · 6 comments

Comments

@ZacSweers
Copy link

There's an animation bug with this on pre-lollipop where the dot to the right side disappears during the transition.

See: http://webmshare.com/dLEEL

I think it's due to the change to addPath, which I don't think it a like-for-like equivelant to Path.Op.UNION.

@ZacSweers
Copy link
Author

Whoops hit enter to soon, editing

@DavidPacioianu
Copy link
Owner

@hzsweers Is this bug still persisting? I can't reproduce it.

@ZacSweers
Copy link
Author

Yes. Try any API 16 device

@leonardo2204
Copy link

I'm facing this problem, but all the dots disappear suddenly.
Sometimes they show, sometimes they don't, only the selected one gets shown.
Also on API 16.
I'll try to find the issue.

@matrixxun
Copy link

matrixxun commented Jul 4, 2016

Another issue, when pager count reached 10+, the option's animation becoming very slow and jerky. I think it's due to the change path.op to path.addPath, So I changed the code as:

if(Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) { combinedUnselectedPath.op(getUnselectedPath(page, dotCenterX[page], dotCenterX[nextXIndex], page == pageCount - 1 ? INVALID_FRACTION : joiningFractions[page], dotRevealFractions[page]), Path.Op.UNION); }else { combinedUnselectedPath.addPath(getUnselectedPath(page, dotCenterX[page], dotCenterX[nextXIndex], page == pageCount - 1 ? INVALID_FRACTION : joiningFractions[page], dotRevealFractions[page])); }

@DavidPacioianu
Copy link
Owner

@matrixxun Please make a pull request with your change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants